diff options
| author | John Ogness <john.ogness@linutronix.de> | 2022-11-16 17:27:48 +0106 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2022-12-02 11:25:02 +0100 |
| commit | 66857443699b34c8c5951dd421f1c528c9554bb5 (patch) | |
| tree | c6886c5bebf95fa4abac01631da92fa25627f45a /drivers/tty | |
| parent | 7e537af997748ea7a8df3f2b234a877ea9ef7791 (diff) | |
| download | linux-66857443699b34c8c5951dd421f1c528c9554bb5.tar.bz2 | |
tty: serial: kgdboc: use console_list_lock for list traversal
configure_kgdboc() uses the console_lock for console list iteration. Use
the console_list_lock instead because list synchronization responsibility
will be removed from the console_lock in a later change.
The SRCU iterator could have been used here, but a later change will
relocate the locking of the console_list_lock to also provide
synchronization against register_console().
Note, the console_lock is still needed to serialize the device()
callback with other console operations.
Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20221116162152.193147-37-john.ogness@linutronix.de
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/kgdboc.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c index c6df9ef34099..82b4b4d67823 100644 --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -193,7 +193,16 @@ static int configure_kgdboc(void) if (!p) goto noconfig; + /* For safe traversal of the console list. */ + console_list_lock(); + + /* + * Take console_lock to serialize device() callback with + * other console operations. For example, fg_console is + * modified under console_lock when switching vt. + */ console_lock(); + for_each_console(cons) { int idx; if (cons->device && cons->device(cons, &idx) == p && @@ -202,8 +211,11 @@ static int configure_kgdboc(void) break; } } + console_unlock(); + console_list_unlock(); + kgdb_tty_driver = p; kgdb_tty_line = tty_line; |