diff options
| author | Peter Hurley <peter@hurleysoftware.com> | 2015-03-09 16:27:17 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-26 16:17:55 +0100 |
| commit | cd385e9a2a2daa7e74003f930886e4c1cdf032f4 (patch) | |
| tree | 3ef3dfeaafeada0b1c859b6ebb386aaa78826c11 /drivers/tty/serial/8250/8250_early.c | |
| parent | 0e3e143e5d1e7be65331cdf6d100b08bc6c15b72 (diff) | |
| download | linux-cd385e9a2a2daa7e74003f930886e4c1cdf032f4.tar.bz2 | |
serial: 8250_early: Fix setup() error code
If parsing failed to decode a valid uart addr, return -ENODEV instead
of success. Although setup_earlycon() will detect the failure anyway
(because the write() method has not been set), that behavior is not
obvious and should not be relied on.
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/8250/8250_early.c')
| -rw-r--r-- | drivers/tty/serial/8250/8250_early.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c index 1701d00fd9f6..b199c10689f4 100644 --- a/drivers/tty/serial/8250/8250_early.c +++ b/drivers/tty/serial/8250/8250_early.c @@ -146,7 +146,7 @@ static int __init early_serial8250_setup(struct earlycon_device *device, const char *options) { if (!(device->port.membase || device->port.iobase)) - return 0; + return -ENODEV; if (!device->baud) { struct uart_port *port = &device->port; |