diff options
author | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> | 2021-06-28 11:32:32 -0700 |
---|---|---|
committer | Daniel Lezcano <daniel.lezcano@linaro.org> | 2021-07-04 18:28:04 +0200 |
commit | ad079d981db6a4047b60c576df6430bed36bcd7d (patch) | |
tree | e5905d1f730ca692a2cc2546c67f06d8a071b1e4 /drivers/thermal/intel/int340x_thermal | |
parent | 24e21d9f40ec3fb4228e3427454b733316a2a6c6 (diff) | |
download | linux-ad079d981db6a4047b60c576df6430bed36bcd7d.tar.bz2 |
thermal/drivers/int340x/processor_thermal: Fix warning for return value
Fix smatch warnings:
drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c:258 proc_thermal_pci_probe() warn: missing error code 'ret'
Use PTR_ERR to return failure of thermal_zone_device_register().
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210628183232.62877-1-srinivas.pandruvada@linux.intel.com
Diffstat (limited to 'drivers/thermal/intel/int340x_thermal')
-rw-r--r-- | drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c index ad7e2e305abf..11dd2e825f4f 100644 --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c @@ -254,8 +254,10 @@ static int proc_thermal_pci_probe(struct pci_dev *pdev, const struct pci_device_ pci_info->tzone = thermal_zone_device_register("TCPU_PCI", 1, 1, pci_info, &tzone_ops, &tzone_params, 0, 0); - if (IS_ERR(pci_info->tzone)) + if (IS_ERR(pci_info->tzone)) { + ret = PTR_ERR(pci_info->tzone); goto err_ret_mmio; + } /* request and enable interrupt */ ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); |