diff options
| author | Dan Williams <dan.j.williams@intel.com> | 2020-02-27 21:39:23 -0800 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2020-03-17 12:23:21 -0700 |
| commit | 6acd7d5ef264d8e9a8988cebf6eeb3567eaf60c6 (patch) | |
| tree | 38b3ebe83d3d4dbd380c7da6e7769f8a17c92463 /drivers/tc | |
| parent | b2ba7e91fa81bec9b64c47ab852145559cad2b68 (diff) | |
| download | linux-6acd7d5ef264d8e9a8988cebf6eeb3567eaf60c6.tar.bz2 | |
libnvdimm/namespace: Enforce memremap_compat_align()
The pmem driver on PowerPC crashes with the following signature when
instantiating misaligned namespaces that map their capacity via
memremap_pages().
BUG: Unable to handle kernel data access at 0xc001000406000000
Faulting instruction address: 0xc000000000090790
NIP [c000000000090790] arch_add_memory+0xc0/0x130
LR [c000000000090744] arch_add_memory+0x74/0x130
Call Trace:
arch_add_memory+0x74/0x130 (unreliable)
memremap_pages+0x74c/0xa30
devm_memremap_pages+0x3c/0xa0
pmem_attach_disk+0x188/0x770
nvdimm_bus_probe+0xd8/0x470
With the assumption that only memremap_pages() has alignment
constraints, enforce memremap_compat_align() for
pmem_should_map_pages(), nd_pfn, and nd_dax cases. This includes
preventing the creation of namespaces where the base address is
misaligned and cases there infoblock padding parameters are invalid.
Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Cc: Jeff Moyer <jmoyer@redhat.com>
Fixes: a3619190d62e ("libnvdimm/pfn: stop padding pmem namespaces to section alignment")
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/tc')
0 files changed, 0 insertions, 0 deletions