summaryrefslogtreecommitdiffstats
path: root/drivers/target
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2018-04-10 20:38:42 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2018-04-20 19:14:37 -0400
commit4011f07660e0c909e25ea2c09ad4761c26c0b8df (patch)
treea06849376cd9c87197b1277592398eff2f0add31 /drivers/target
parent1f618aac2f00d3d9a4942cda14b8c33d28a11840 (diff)
downloadlinux-4011f07660e0c909e25ea2c09ad4761c26c0b8df.tar.bz2
scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in new_tape_buffer
new_tape_buffer() is never called in atomic context. new_tape_buffer() is only called by st_probe(), which is only set as ".probe" in struct scsi_driver. Despite never getting called from atomic context, new_tape_buffer() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target')
0 files changed, 0 insertions, 0 deletions