diff options
| author | Michael Straube <straube.linux@gmail.com> | 2022-07-30 17:06:36 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-08-16 15:14:19 +0200 |
| commit | c026b483f8f2eff1478f7edd55a2aef4cf9ebc2e (patch) | |
| tree | 4dee47aa9ee8be85c14cec8d0586873032d82bb3 /drivers/staging | |
| parent | c8d3347e3039cee0e0394fb9c83fcf1efc92b4af (diff) | |
| download | linux-c026b483f8f2eff1478f7edd55a2aef4cf9ebc2e.tar.bz2 | |
staging: r8188eu: convert dump_chip_info() to use netdev_dbg()
Drivers should not spam the kernel log if they work properly. Convert
the dump_chip_info() function to use netdev_dbg() instead of pr_info()
so that developers can still enable it if they want to see this
information.
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220730150637.3550-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c index 5b8f1a912bbb..012828a05e6c 100644 --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c @@ -526,8 +526,9 @@ void rtl8188e_ReadEFuse(struct adapter *Adapter, u16 _size_byte, u8 *pbuf) Hal_EfuseReadEFuse88E(Adapter, 0, _size_byte, pbuf); } -static void dump_chip_info(struct HAL_VERSION chip_vers) +static void dump_chip_info(struct adapter *adapter, struct HAL_VERSION chip_vers) { + struct net_device *netdev = adapter->pnetdev; uint cnt = 0; char buf[128]; @@ -560,9 +561,9 @@ static void dump_chip_info(struct HAL_VERSION chip_vers) cnt += sprintf((buf + cnt), "1T1R_"); - cnt += sprintf((buf + cnt), "RomVer(%d)\n", 0); + cnt += sprintf((buf + cnt), "RomVer(%d)", 0); - pr_info("%s", buf); + netdev_dbg(netdev, "%s\n", buf); } void rtl8188e_read_chip_version(struct adapter *padapter) @@ -581,7 +582,7 @@ void rtl8188e_read_chip_version(struct adapter *padapter) ChipVersion.VendorType = ((value32 & VENDOR_ID) ? CHIP_VENDOR_UMC : CHIP_VENDOR_TSMC); ChipVersion.CUTVersion = (value32 & CHIP_VER_RTL_MASK) >> CHIP_VER_RTL_SHIFT; /* IC version (CUT) */ - dump_chip_info(ChipVersion); + dump_chip_info(padapter, ChipVersion); pHalData->VersionID = ChipVersion; } |