diff options
| author | Jiayi Ye <yejiayily@gmail.com> | 2014-10-20 15:01:08 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-10-23 14:10:49 +0800 |
| commit | b0ef3ed48eb8c1982c9d8b8063d856c83d116764 (patch) | |
| tree | 589404289ddcf0715fd1e647a83c573220e98192 /drivers/staging/rts5208 | |
| parent | cb6c1ee3057ebb717fd4439711b3cb5354d5085f (diff) | |
| download | linux-b0ef3ed48eb8c1982c9d8b8063d856c83d116764.tar.bz2 | |
staging: rts5208: fix case of bitwise operator on zero in ms.c
If a variable has value 0, then there is no point in combining it with other things with |, as for any
x, 0 | x is just x. The following semantic patch finds this problem.
@@
expression x,e,e1;
statement S;
@@
if (x == 0) {
<... when != x = e1
when != while(...) S
when != for(...;...;...) S
(
* x |= e
|
* x | e
)
...>
}
Signed-off-by: Jiayi Ye <yejiayily@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/rts5208')
| -rw-r--r-- | drivers/staging/rts5208/ms.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index 228e48339b9e..b4612fb615f6 100644 --- a/drivers/staging/rts5208/ms.c +++ b/drivers/staging/rts5208/ms.c @@ -2599,9 +2599,9 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb, if (count > sector_cnt) { if (mode_2k) - ms_card->seq_mode |= MODE_2K_SEQ; + ms_card->seq_mode = MODE_2K_SEQ; else - ms_card->seq_mode |= MODE_512_SEQ; + ms_card->seq_mode = MODE_512_SEQ; } } else { count = sector_cnt; |