diff options
author | Ioana Ciornei <ioana.ciornei@nxp.com> | 2020-07-21 12:19:17 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-07-21 16:53:34 +0200 |
commit | adcdd57d5feab928d58959956844a6b755a41650 (patch) | |
tree | a7ca7c9e17a528c0ffd27bfd014ac75199c0fd95 /drivers/staging/fsl-dpaa2/ethsw | |
parent | 4acfc4393e90e4dfa6ebc6e43545296ca1d928fe (diff) | |
download | linux-adcdd57d5feab928d58959956844a6b755a41650.tar.bz2 |
staging: dpaa2-ethsw: destroy workqueue after deregistering the notifiers
We should destroy the switch workqueue only after deregistering the
switchdev notifiers. Without this fix, we could end up with switchdev
notifications on a draining workqueue and also with a lock up since the
netdevice reference count is increased (in port_switchdev_event) and not
decreased ever (since the workqueue did not run).
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/20200721091919.20394-5-ioana.ciornei@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/fsl-dpaa2/ethsw')
-rw-r--r-- | drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index c620ee23227b..c4267ef44597 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -1628,8 +1628,6 @@ static int ethsw_remove(struct fsl_mc_device *sw_dev) ethsw_teardown_irqs(sw_dev); - destroy_workqueue(ethsw->workqueue); - dpsw_disable(ethsw->mc_io, 0, ethsw->dpsw_handle); for (i = 0; i < ethsw->sw_attr.num_ifs; i++) { @@ -1640,6 +1638,9 @@ static int ethsw_remove(struct fsl_mc_device *sw_dev) kfree(ethsw->ports); ethsw_takedown(sw_dev); + + destroy_workqueue(ethsw->workqueue); + fsl_mc_portal_free(ethsw->mc_io); kfree(ethsw); |