diff options
| author | Wolfgang Bumiller <w.bumiller@proxmox.com> | 2018-04-12 10:46:55 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-04-12 22:01:22 -0400 |
| commit | 53b76cdf7e8fecec1d09e38aad2f8579882591a8 (patch) | |
| tree | 1c6912ae100a38fd342e72324cd2d93edc38b161 /drivers/ssb/driver_gpio.c | |
| parent | 1071ec9d453a38023579714b64a951a2fb982071 (diff) | |
| download | linux-53b76cdf7e8fecec1d09e38aad2f8579882591a8.tar.bz2 | |
net: fix deadlock while clearing neighbor proxy table
When coming from ndisc_netdev_event() in net/ipv6/ndisc.c,
neigh_ifdown() is called with &nd_tbl, locking this while
clearing the proxy neighbor entries when eg. deleting an
interface. Calling the table's pndisc_destructor() with the
lock still held, however, can cause a deadlock: When a
multicast listener is available an IGMP packet of type
ICMPV6_MGM_REDUCTION may be sent out. When reaching
ip6_finish_output2(), if no neighbor entry for the target
address is found, __neigh_create() is called with &nd_tbl,
which it'll want to lock.
Move the elements into their own list, then unlock the table
and perform the destruction.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199289
Fixes: 6fd6ce2056de ("ipv6: Do not depend on rt->n in ip6_finish_output2().")
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/ssb/driver_gpio.c')
0 files changed, 0 insertions, 0 deletions