diff options
| author | Marek Vasut <marex@denx.de> | 2022-08-12 19:08:02 +0200 |
|---|---|---|
| committer | Shawn Guo <shawnguo@kernel.org> | 2022-08-21 21:34:48 +0800 |
| commit | df88005bd81b80c944d185554e264a4b0f993c37 (patch) | |
| tree | 981b590adea784e70c0e7fcf03431848aa4cdfc8 /drivers/soc/imx | |
| parent | e7406f864e765c564c5cf384464faff66114f97d (diff) | |
| download | linux-df88005bd81b80c944d185554e264a4b0f993c37.tar.bz2 | |
soc: imx: gpcv2: Assert reset before ungating clock
In case the power domain clock are ungated before the reset is asserted,
the system might freeze completely. This is likely due to a device is an
undefined state being attached to bus, which sporadically leads to a bus
hang. Assert the reset before the clock are enabled to assure the device
is in defined state before being attached to bus.
Fixes: fe58c887fb8ca ("soc: imx: gpcv2: add support for optional resets")
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/soc/imx')
| -rw-r--r-- | drivers/soc/imx/gpcv2.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 6383a4edc360..88aee59730e3 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -335,6 +335,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) } } + reset_control_assert(domain->reset); + /* Enable reset clocks for all devices in the domain */ ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); if (ret) { @@ -342,7 +344,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) goto out_regulator_disable; } - reset_control_assert(domain->reset); + /* delays for reset to propagate */ + udelay(5); if (domain->bits.pxx) { /* request the domain to power up */ |