summaryrefslogtreecommitdiffstats
path: root/drivers/soc/imx
diff options
context:
space:
mode:
authorMiaoqian Lin <linmq006@gmail.com>2022-12-31 13:58:48 +0400
committerShawn Guo <shawnguo@kernel.org>2023-01-02 21:16:05 +0800
commit490748874ebf1875420fc29b335bba2075dd1b5e (patch)
treead508b2cab124798e8c040f1e4617da24259f022 /drivers/soc/imx
parentae066f374687d7dd06bb8c732f66d6ab3c3fd480 (diff)
downloadlinux-490748874ebf1875420fc29b335bba2075dd1b5e.tar.bz2
soc: imx8m: Fix incorrect check for of_clk_get_by_name()
of_clk_get_by_name() returns error pointers instead of NULL. Use IS_ERR() checks the return value to catch errors. Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/soc/imx')
-rw-r--r--drivers/soc/imx/soc-imx8m.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..32ed9dc88e45 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,8 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
ocotp_base = of_iomap(np, 0);
WARN_ON(!ocotp_base);
clk = of_clk_get_by_name(np, NULL);
- if (!clk) {
- WARN_ON(!clk);
+ if (IS_ERR(clk)) {
+ WARN_ON(IS_ERR(clk));
return 0;
}