diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2021-12-03 15:19:39 -0800 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2021-12-06 22:30:33 -0500 |
| commit | 21ad0e49085deb22c094f91f9da57319a97188e4 (patch) | |
| tree | 29743ea1c2c88e816f0df6dfc60c17f6dd4f5c41 /drivers/scsi/ufs/tc-dwc-g210-pci.c | |
| parent | d77ea8226b3be23b0b45aa42851243b62a27bda1 (diff) | |
| download | linux-21ad0e49085deb22c094f91f9da57319a97188e4.tar.bz2 | |
scsi: ufs: Fix race conditions related to driver data
The driver data pointer must be set before any callbacks are registered
that use that pointer. Hence move the initialization of that pointer from
after the ufshcd_init() call to inside ufshcd_init().
Link: https://lore.kernel.org/r/20211203231950.193369-7-bvanassche@acm.org
Fixes: 3b1d05807a9a ("[SCSI] ufs: Segregate PCI Specific Code")
Reported-by: Alexey Dobriyan <adobriyan@gmail.com>
Tested-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/ufs/tc-dwc-g210-pci.c')
| -rw-r--r-- | drivers/scsi/ufs/tc-dwc-g210-pci.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/tc-dwc-g210-pci.c b/drivers/scsi/ufs/tc-dwc-g210-pci.c index 679289e1a78e..7b08e2e07cc5 100644 --- a/drivers/scsi/ufs/tc-dwc-g210-pci.c +++ b/drivers/scsi/ufs/tc-dwc-g210-pci.c @@ -110,7 +110,6 @@ tc_dwc_g210_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) return err; } - pci_set_drvdata(pdev, hba); pm_runtime_put_noidle(&pdev->dev); pm_runtime_allow(&pdev->dev); |