summaryrefslogtreecommitdiffstats
path: root/drivers/pwm/pwm-pxa.c
diff options
context:
space:
mode:
authorMike Dunn <mikedunn@newsguy.com>2013-08-08 10:00:37 -0700
committerThierry Reding <thierry.reding@gmail.com>2013-09-03 13:09:17 +0200
commit1e185c7aafbb56580feaa5bdbc9e4b1d8efaf710 (patch)
tree802a9dd5436b907cb78355599674ac7e085d620a /drivers/pwm/pwm-pxa.c
parentac872bc9ed4452dccfbcebe7d273350103464998 (diff)
downloadlinux-1e185c7aafbb56580feaa5bdbc9e4b1d8efaf710.tar.bz2
pwm: pxa: Use module_platform_driver
Commit 76abbdde2d95a3807d0dc6bf9f84d03d0dbd4f3d pwm: Add sysfs interface causes a kernel oops due to a null pointer dereference on PXA platforms. This happens because the class added by the patch is registered in a subsys_initcall (initcall4), but the pxa pwm driver is registered in arch_initcall (initcall3). If the class is not registered before the driver probe function runs, the oops occurs in device_add() when the uninitialized pointers in struct class are dereferenced. I don't see a reason that the driver must be an arch_initcall, so this patch makes it a regular module_platform_driver (initcall6), preventing the oops. Signed-off-by: Mike Dunn <mikedunn@newsguy.com> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Acked-by: Marek Vasut <marex@denx.de> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-pxa.c')
-rw-r--r--drivers/pwm/pwm-pxa.c12
1 files changed, 1 insertions, 11 deletions
diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
index dc9717551d39..a4d2164aaf55 100644
--- a/drivers/pwm/pwm-pxa.c
+++ b/drivers/pwm/pwm-pxa.c
@@ -182,16 +182,6 @@ static struct platform_driver pwm_driver = {
.id_table = pwm_id_table,
};
-static int __init pwm_init(void)
-{
- return platform_driver_register(&pwm_driver);
-}
-arch_initcall(pwm_init);
-
-static void __exit pwm_exit(void)
-{
- platform_driver_unregister(&pwm_driver);
-}
-module_exit(pwm_exit);
+module_platform_driver(pwm_driver);
MODULE_LICENSE("GPL v2");