summaryrefslogtreecommitdiffstats
path: root/drivers/pwm/pwm-meson.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2020-09-03 13:23:25 +0200
committerHans de Goede <hdegoede@redhat.com>2020-09-06 15:38:00 +0200
commit092d83e3f513a4a7b9f189b34e28b71c9edcedbd (patch)
tree8a9808bed2c83b65ce6dae2505d7e1dc0deeaae5 /drivers/pwm/pwm-meson.c
parentef9f60daab309558c8bb3e086a9a11ee40bd6061 (diff)
downloadlinux-092d83e3f513a4a7b9f189b34e28b71c9edcedbd.tar.bz2
pwm: lpss: Add pwm_lpss_prepare_enable() helper
In the not-enabled -> enabled path pwm_lpss_apply() needs to get a runtime-pm reference; and then on any errors it needs to release it again. This leads to somewhat hard to read code. This commit introduces a new pwm_lpss_prepare_enable() helper and moves all the steps necessary for the not-enabled -> enabled transition there, so that we can error check the entire transition in a single place and only have one pm_runtime_put() on failure call site. While working on this I noticed that the enabled -> enabled (update settings) path was quite similar, so I've added an enable parameter to the new pwm_lpss_prepare_enable() helper, which allows using it in that path too. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Thierry Reding <thierry.reding@gmail.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200903112337.4113-6-hdegoede@redhat.com
Diffstat (limited to 'drivers/pwm/pwm-meson.c')
0 files changed, 0 insertions, 0 deletions