summaryrefslogtreecommitdiffstats
path: root/drivers/power
diff options
context:
space:
mode:
authorQiheng Lin <linqiheng@huawei.com>2022-11-28 22:27:40 +0800
committerSebastian Reichel <sebastian.reichel@collabora.com>2022-12-03 02:03:24 +0100
commit54c03bfd094fb74f9533a9c28250219afe182382 (patch)
treed685168642b586563a3f255a0d1b8075a83ca678 /drivers/power
parent571650b3a30f67d70df242508631ed5e7de2c2df (diff)
downloadlinux-54c03bfd094fb74f9533a9c28250219afe182382.tar.bz2
power: supply: Fix refcount leak in rk817_charger_probe
of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817") Signed-off-by: Qiheng Lin <linqiheng@huawei.com> Reviewed-by: Chris Morgan <macromorgan@hotmail.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to 'drivers/power')
-rw-r--r--drivers/power/supply/rk817_charger.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 635f051b0821..d25a81d79fac 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1060,8 +1060,10 @@ static int rk817_charger_probe(struct platform_device *pdev)
return -ENODEV;
charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
- if (!charger)
+ if (!charger) {
+ of_node_put(node);
return -ENOMEM;
+ }
charger->rk808 = rk808;