summaryrefslogtreecommitdiffstats
path: root/drivers/pci/pci-sysfs.c
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2015-10-07 11:03:28 -0500
committerBjorn Helgaas <bhelgaas@google.com>2015-10-07 11:03:28 -0500
commit1266963170f576d4d08e6310b6963e26d3ff9d1e (patch)
treef7f1b34cd29a898d802a0730eefe4f7c8aa7fcf6 /drivers/pci/pci-sysfs.c
parentde24c18c0faca5ebd618e1cb87f5489745e40475 (diff)
downloadlinux-1266963170f576d4d08e6310b6963e26d3ff9d1e.tar.bz2
PCI: Prevent out of bounds access in numa_node override
63692df103e9 ("PCI: Allow numa_node override via sysfs") didn't check that the numa node provided by userspace is valid. Passing a node number too high would attempt to access invalid memory and trigger a kernel panic. Fixes: 63692df103e9 ("PCI: Allow numa_node override via sysfs") Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: stable@vger.kernel.org # v3.19+
Diffstat (limited to 'drivers/pci/pci-sysfs.c')
-rw-r--r--drivers/pci/pci-sysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 312f23a8429c..92618686604c 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -216,7 +216,7 @@ static ssize_t numa_node_store(struct device *dev,
if (ret)
return ret;
- if (!node_online(node))
+ if (node >= MAX_NUMNODES || !node_online(node))
return -EINVAL;
add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);