diff options
| author | Sagi Grimberg <sagi@grimberg.me> | 2022-02-01 14:54:20 +0200 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2022-02-02 09:19:07 +0100 |
| commit | ff9fc7ebf5c06de1ef72a69f9b1ab40af8b07f9e (patch) | |
| tree | c6603cffc5eb1d095d64a43715838734144c078d /drivers/nvme | |
| parent | 0fa0f99fc84e41057cbdd2efbfe91c6b2f47dd9d (diff) | |
| download | linux-ff9fc7ebf5c06de1ef72a69f9b1ab40af8b07f9e.tar.bz2 | |
nvme-tcp: fix possible use-after-free in transport error_recovery work
While nvme_tcp_submit_async_event_work is checking the ctrl and queue
state before preparing the AER command and scheduling io_work, in order
to fully prevent a race where this check is not reliable the error
recovery work must flush async_event_work before continuing to destroy
the admin queue after setting the ctrl state to RESETTING such that
there is no race .submit_async_event and the error recovery handler
itself changing the ctrl state.
Tested-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/tcp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 4ceb28675fdf..01e24b5703db 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -2096,6 +2096,7 @@ static void nvme_tcp_error_recovery_work(struct work_struct *work) struct nvme_ctrl *ctrl = &tcp_ctrl->ctrl; nvme_stop_keep_alive(ctrl); + flush_work(&ctrl->async_event_work); nvme_tcp_teardown_io_queues(ctrl, false); /* unquiesce to fail fast pending requests */ nvme_start_queues(ctrl); |