diff options
| author | Keith Busch <kbusch@kernel.org> | 2023-01-18 08:44:16 -0800 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2023-01-19 09:08:01 +0100 |
| commit | 1c5842085851f786eba24a39ecd02650ad892064 (patch) | |
| tree | 352ee97926f7f9c8a347d8109fbbffdb7607b4b6 /drivers/nvme | |
| parent | c0a4a1eafbd48e02829045bba3e6163c03037276 (diff) | |
| download | linux-1c5842085851f786eba24a39ecd02650ad892064.tar.bz2 | |
nvme-pci: fix timeout request state check
Polling the completion can progress the request state to IDLE, either
inline with the completion, or through softirq. Either way, the state
may not be COMPLETED, so don't check for that. We only care if the state
isn't IN_FLIGHT.
This is fixing an issue where the driver aborts an IO that we just
completed. Seeing the "aborting" message instead of "polled" is very
misleading as to where the timeout problem resides.
Fixes: bf392a5dc02a9b ("nvme-pci: Remove tag from process cq")
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index a2553b7d9bb8..1ff8843bc4b3 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -1362,7 +1362,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req) else nvme_poll_irqdisable(nvmeq); - if (blk_mq_request_completed(req)) { + if (blk_mq_rq_state(req) != MQ_RQ_IN_FLIGHT) { dev_warn(dev->ctrl.device, "I/O %d QID %d timeout, completion polled\n", req->tag, nvmeq->qid); |