summaryrefslogtreecommitdiffstats
path: root/drivers/nvme/host/multipath.c
diff options
context:
space:
mode:
authorDaniel Wagner <dwagner@suse.de>2021-06-07 10:46:51 +0200
committerChristoph Hellwig <hch@lst.de>2021-06-16 05:36:15 +0200
commit2411424143bdfad3027e82fe6a66c5aadce271ee (patch)
tree81d2ae6dfa24c98e2aca15562c5276aa758b6ce0 /drivers/nvme/host/multipath.c
parent120bb3624d55d65145f7c1bf12a839fd323cde29 (diff)
downloadlinux-2411424143bdfad3027e82fe6a66c5aadce271ee.tar.bz2
nvme: remove superfluous bio_set_dev in nvme_requeue_work
Commit ce86dad222e9 ("nvme-multipath: reset bdev to ns head when failover") moved the reset code where the bio is added to the requeue_list for the failover path. But it left the original bio_set_dev in nvme_requeue_work. There is a second path to nvme_requee_work. It is via nvme_ns_head_submit_bio. Though we don't have to set bio->bi_bdev for this path either, as it points to the correct bdev already. Let's remove the bio_set_dev. It's updating the bio->bi_bdev with the same pointer and thus it's unnecessary. Signed-off-by: Daniel Wagner <dwagner@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/host/multipath.c')
-rw-r--r--drivers/nvme/host/multipath.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 98426234d416..23573fe3fc7d 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -435,11 +435,6 @@ static void nvme_requeue_work(struct work_struct *work)
next = bio->bi_next;
bio->bi_next = NULL;
- /*
- * Reset disk to the mpath node and resubmit to select a new
- * path.
- */
- bio_set_dev(bio, head->disk->part0);
submit_bio_noacct(bio);
}
}