summaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2021-04-13 01:19:16 -0400
committerMichael S. Tsirkin <mst@redhat.com>2021-07-03 04:51:18 -0400
commit8d622d21d24803408b256d96463eac4574dcf067 (patch)
tree9ffde8a09795cec4842efa950726c5d0c3124088 /drivers/net
parent22bc63c58e876cc359d0b1566dee3db8ecc16722 (diff)
downloadlinux-8d622d21d24803408b256d96463eac4574dcf067.tar.bz2
virtio: fix up virtio_disable_cb
virtio_disable_cb is currently a nop for split ring with event index. This is because it used to be always called from a callback when we know device won't trigger more events until we update the index. However, now that we run with interrupts enabled a lot we also poll without a callback so that is different: disabling callbacks will help reduce the number of spurious interrupts. Further, if using event index with a packed ring, and if being called from a callback, we actually do disable interrupts which is unnecessary. Fix both issues by tracking whenever we get a callback. If that is the case disabling interrupts with event index can be a nop. If not the case disable interrupts. Note: with a split ring there's no explicit "no interrupts" value. For now we write a fixed value so our chance of triggering an interupt is 1/ring size. It's probably better to write something related to the last used index there to reduce the chance even further. For now I'm keeping it simple. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions