diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-24 18:34:08 -0600 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2020-03-23 18:55:04 +0200 |
| commit | 398978f7dfa551abff9361f40db951c3c982fa5e (patch) | |
| tree | 0cec7bd55f62ed3cb9e179caae4448d6549e933a /drivers/net/wireless/ti/wlcore/boot.h | |
| parent | a1b7714b72fd2ba5dead01b465a9e37863051eff (diff) | |
| download | linux-398978f7dfa551abff9361f40db951c3c982fa5e.tar.bz2 | |
wireless: ti: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200225003408.GA28675@embeddedor
Diffstat (limited to 'drivers/net/wireless/ti/wlcore/boot.h')
| -rw-r--r-- | drivers/net/wireless/ti/wlcore/boot.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/ti/wlcore/boot.h b/drivers/net/wireless/ti/wlcore/boot.h index 14b367e98dce..24a2dfcb41ea 100644 --- a/drivers/net/wireless/ti/wlcore/boot.h +++ b/drivers/net/wireless/ti/wlcore/boot.h @@ -26,7 +26,7 @@ struct wl1271_static_data { u8 fw_version[WL1271_FW_VERSION_MAX_LEN]; u32 hw_version; u8 tx_power_table[WL1271_NO_SUBBANDS][WL1271_NO_POWER_LEVELS]; - u8 priv[0]; + u8 priv[]; }; /* number of times we try to read the INIT interrupt */ |