diff options
| author | Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-04 00:29:34 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2019-10-02 07:16:10 +0300 |
| commit | ab8c31dd8c8accea11bd59075bca711579512adc (patch) | |
| tree | 25fa844f1e9561b15632cdb4876070a13dfda2b1 /drivers/net/wireless/st/cw1200/queue.c | |
| parent | 0a3ce169476feca7869255c681884ed227a319c8 (diff) | |
| download | linux-ab8c31dd8c8accea11bd59075bca711579512adc.tar.bz2 | |
net/wireless: Use kmemdup rather than duplicating its implementation
kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/st/cw1200/queue.c')
| -rw-r--r-- | drivers/net/wireless/st/cw1200/queue.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/st/cw1200/queue.c b/drivers/net/wireless/st/cw1200/queue.c index 14133eedb3b6..12952b1c29df 100644 --- a/drivers/net/wireless/st/cw1200/queue.c +++ b/drivers/net/wireless/st/cw1200/queue.c @@ -79,10 +79,9 @@ static void cw1200_queue_register_post_gc(struct list_head *gc_list, struct cw1200_queue_item *item) { struct cw1200_queue_item *gc_item; - gc_item = kmalloc(sizeof(struct cw1200_queue_item), + gc_item = kmemdup(item, sizeof(struct cw1200_queue_item), GFP_ATOMIC); BUG_ON(!gc_item); - memcpy(gc_item, item, sizeof(struct cw1200_queue_item)); list_add_tail(&gc_item->head, gc_list); } |