summaryrefslogtreecommitdiffstats
path: root/drivers/net/slip
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2012-03-14 08:53:34 +0000
committerDavid S. Miller <davem@davemloft.net>2012-03-16 02:01:17 -0700
commitbb6d5e76fb4fba9aa36726db41404512f3286c0f (patch)
tree58858ab2c09fe9179dcf4c26da83bbd9c3783211 /drivers/net/slip
parent7bdd402706cf26bfef9050dfee3f229b7f33ee4f (diff)
downloadlinux-bb6d5e76fb4fba9aa36726db41404512f3286c0f.tar.bz2
net/hyperv: fix erroneous NETDEV_TX_BUSY use
A driver start_xmit() method cannot free skb and return NETDEV_TX_BUSY, since caller is going to reuse freed skb. This is mostly a revert of commit bf769375c (staging: hv: fix the return status of netvsc_start_xmit()) In fact netif_tx_stop_queue() / netif_stop_queue() is needed before returning NETDEV_TX_BUSY or you can trigger a ksoftirqd fatal loop. In case of memory allocation error, only safe way is to drop the packet and return NETDEV_TX_OK Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/slip')
0 files changed, 0 insertions, 0 deletions