diff options
| author | Tom Rix <trix@redhat.com> | 2020-08-02 07:23:39 -0700 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2020-08-03 20:19:21 +0200 |
| commit | e3914ed6cf44bfe1f169e26241f8314556fd1ac1 (patch) | |
| tree | 1eaefb94fcd4d9025632522588ad020ef5d8cd76 /drivers/net/ieee802154 | |
| parent | 88f46b3fe2ac41c381770ebad9f2ee49346b57a2 (diff) | |
| download | linux-e3914ed6cf44bfe1f169e26241f8314556fd1ac1.tar.bz2 | |
ieee802154/adf7242: check status of adf7242_read_reg
Clang static analysis reports this error
adf7242.c:887:6: warning: Assigned value is garbage or undefined
len = len_u8;
^ ~~~~~~
len_u8 is set in
adf7242_read_reg(lp, 0, &len_u8);
When this call fails, len_u8 is not set.
So check the return code.
Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20200802142339.21091-1-trix@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'drivers/net/ieee802154')
| -rw-r--r-- | drivers/net/ieee802154/adf7242.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index c11f32f644db..7db9cbd0f5de 100644 --- a/drivers/net/ieee802154/adf7242.c +++ b/drivers/net/ieee802154/adf7242.c @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp) int ret; u8 lqi, len_u8, *data; - adf7242_read_reg(lp, 0, &len_u8); + ret = adf7242_read_reg(lp, 0, &len_u8); + if (ret) + return ret; len = len_u8; |