diff options
| author | Valentina Goncharenko <goncharenko.vp@ispras.ru> | 2022-12-01 20:34:08 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-05 09:46:31 +0000 |
| commit | 25f427ac7b8d89b0259f86c0c6407b329df742b2 (patch) | |
| tree | e37a5034ab0348d50cfdae9fc5dd8872c03ce7a6 /drivers/net/ethernet/microchip/encx24j600-regmap.c | |
| parent | 167b3f2dcc62c271f3555b33df17e361bb1fa0ee (diff) | |
| download | linux-25f427ac7b8d89b0259f86c0c6407b329df742b2.tar.bz2 | |
net: encx24j600: Fix invalid logic in reading of MISTAT register
A loop for reading MISTAT register continues while regmap_read() fails
and (mistat & BUSY), but if regmap_read() fails a value of mistat is
undefined.
The patch proposes to check for BUSY flag only when regmap_read()
succeed. Compile test only.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: d70e53262f5c ("net: Microchip encx24j600 driver")
Signed-off-by: Valentina Goncharenko <goncharenko.vp@ispras.ru>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip/encx24j600-regmap.c')
| -rw-r--r-- | drivers/net/ethernet/microchip/encx24j600-regmap.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c index 2e337c7a5773..5693784eec5b 100644 --- a/drivers/net/ethernet/microchip/encx24j600-regmap.c +++ b/drivers/net/ethernet/microchip/encx24j600-regmap.c @@ -359,7 +359,7 @@ static int regmap_encx24j600_phy_reg_read(void *context, unsigned int reg, goto err_out; usleep_range(26, 100); - while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) == 0) && (mistat & BUSY)) cpu_relax(); @@ -397,7 +397,7 @@ static int regmap_encx24j600_phy_reg_write(void *context, unsigned int reg, goto err_out; usleep_range(26, 100); - while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) != 0) && + while (((ret = regmap_read(ctx->regmap, MISTAT, &mistat)) == 0) && (mistat & BUSY)) cpu_relax(); |