diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2014-07-21 19:07:12 -0700 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2014-08-19 11:53:08 -0700 |
| commit | 1001ff7a4f64f3f4264e69d3ed70ff428f627e01 (patch) | |
| tree | 9b673e00fda7873a9958cf5d60f66a49cf2e020c /drivers/mtd/tests/readtest.c | |
| parent | 8c3f3f1d7941bcb25590b784f84accd7dcb44ba3 (diff) | |
| download | linux-1001ff7a4f64f3f4264e69d3ed70ff428f627e01.tar.bz2 | |
mtd: tests: fix integer overflow issues
These multiplications are done with 32-bit arithmetic, then converted to
64-bit. We should widen the integers first to prevent overflow. This
could be a problem for large (>4GB) MTD's.
Detected by Coverity.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Diffstat (limited to 'drivers/mtd/tests/readtest.c')
| -rw-r--r-- | drivers/mtd/tests/readtest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/tests/readtest.c b/drivers/mtd/tests/readtest.c index 626e66d0f7e7..a54cf1511114 100644 --- a/drivers/mtd/tests/readtest.c +++ b/drivers/mtd/tests/readtest.c @@ -47,7 +47,7 @@ static int pgcnt; static int read_eraseblock_by_page(int ebnum) { int i, ret, err = 0; - loff_t addr = ebnum * mtd->erasesize; + loff_t addr = (loff_t)ebnum * mtd->erasesize; void *buf = iobuf; void *oobbuf = iobuf1; |