diff options
| author | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-19 15:00:03 +0200 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-31 10:53:34 +0200 |
| commit | 8fd507bb42104c1aabd557a9a993e8d0376c6fee (patch) | |
| tree | 8621201a169303288d9342803108371046aeee08 /drivers/mtd/nand/raw/mxic_nand.c | |
| parent | c6dc082793d2fc9609e36a7b165624c4ee57d36f (diff) | |
| download | linux-8fd507bb42104c1aabd557a9a993e8d0376c6fee.tar.bz2 | |
mtd: rawnand: mxic: Stop using nand_release()
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-31-miquel.raynal@bootlin.com
Diffstat (limited to 'drivers/mtd/nand/raw/mxic_nand.c')
| -rw-r--r-- | drivers/mtd/nand/raw/mxic_nand.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/mxic_nand.c b/drivers/mtd/nand/raw/mxic_nand.c index 5a5a5b3b546d..57f36721f4c6 100644 --- a/drivers/mtd/nand/raw/mxic_nand.c +++ b/drivers/mtd/nand/raw/mxic_nand.c @@ -556,8 +556,13 @@ fail: static int mxic_nfc_remove(struct platform_device *pdev) { struct mxic_nand_ctlr *nfc = platform_get_drvdata(pdev); + struct nand_chip *chip = &nfc->chip; + int ret; + + ret = mtd_device_unregister(nand_to_mtd(chip)); + WARN_ON(ret); + nand_cleanup(chip); - nand_release(&nfc->chip); mxic_nfc_clk_disable(nfc); return 0; } |