diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-06-03 23:07:45 +0200 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2022-06-09 15:06:13 +0200 |
| commit | 0c90466a7985d39355f743e9cd2139da3e86c4d8 (patch) | |
| tree | 3680ded094a37b5e792e1e87d18ccd77a3af774b /drivers/mtd/hyperbus/hbmc-am654.c | |
| parent | 83208e106a8e8a859110ebb04a5e927ced911afb (diff) | |
| download | linux-0c90466a7985d39355f743e9cd2139da3e86c4d8.tar.bz2 | |
mtd: hyperbus: Make hyperbus_unregister_device() return void
The only thing that could theoretically fail in that function is
mtd_device_unregister(). However it's not supposed to fail and when
used correctly it doesn't. So wail loudly if it does anyhow.
This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220603210758.148493-2-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/mtd/hyperbus/hbmc-am654.c')
| -rw-r--r-- | drivers/mtd/hyperbus/hbmc-am654.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/mtd/hyperbus/hbmc-am654.c b/drivers/mtd/hyperbus/hbmc-am654.c index a3439b791eeb..a6161ce340d4 100644 --- a/drivers/mtd/hyperbus/hbmc-am654.c +++ b/drivers/mtd/hyperbus/hbmc-am654.c @@ -233,16 +233,16 @@ static int am654_hbmc_remove(struct platform_device *pdev) { struct am654_hbmc_priv *priv = platform_get_drvdata(pdev); struct am654_hbmc_device_priv *dev_priv = priv->hbdev.priv; - int ret; - ret = hyperbus_unregister_device(&priv->hbdev); + hyperbus_unregister_device(&priv->hbdev); + if (priv->mux_ctrl) mux_control_deselect(priv->mux_ctrl); if (dev_priv->rx_chan) dma_release_channel(dev_priv->rx_chan); - return ret; + return 0; } static const struct of_device_id am654_hbmc_dt_ids[] = { |