summaryrefslogtreecommitdiffstats
path: root/drivers/mmc/host/sdhci-brcmstb.c
diff options
context:
space:
mode:
authorNathan Chancellor <nathan@kernel.org>2022-06-08 08:27:57 -0700
committerUlf Hansson <ulf.hansson@linaro.org>2022-07-12 12:25:37 +0200
commitc3c0ed75ffbff5c70667030b5139bbb75b0a30f5 (patch)
treee5bdfb2c32c9027dca56473fd495e5b01e179284 /drivers/mmc/host/sdhci-brcmstb.c
parentf78bc9f2caa4e37fafa623faa8f5c683b4c4b35e (diff)
downloadlinux-c3c0ed75ffbff5c70667030b5139bbb75b0a30f5.tar.bz2
mmc: sdhci-brcmstb: Initialize base_clk to NULL in sdhci_brcmstb_probe()
Clang warns a few times along the lines of: drivers/mmc/host/sdhci-brcmstb.c:302:6: warning: variable 'base_clk' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (res) ^~~ drivers/mmc/host/sdhci-brcmstb.c:376:24: note: uninitialized use occurs here clk_disable_unprepare(base_clk); ^~~~~~~~ base_clk is used in the error path before it is initialized. Initialize it to NULL, as clk_disable_unprepare() calls clk_disable() and clk_unprepare(), which both handle NULL pointers gracefully. Link: https://github.com/ClangBuiltLinux/linux/issues/1650 Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Link: https://lore.kernel.org/r/20220608152757.82529-1-nathan@kernel.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc/host/sdhci-brcmstb.c')
-rw-r--r--drivers/mmc/host/sdhci-brcmstb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index f8dff8537920..28e9cf995c41 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -256,7 +256,7 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
struct sdhci_host *host;
struct resource *iomem;
struct clk *clk;
- struct clk *base_clk;
+ struct clk *base_clk = NULL;
int res;
match = of_match_node(sdhci_brcm_of_match, pdev->dev.of_node);