diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-11-11 22:59:29 +0800 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2022-11-24 23:31:44 +1100 |
| commit | 295faa17722a11cac8dbf51e4c9f9405a5e07ef1 (patch) | |
| tree | 1f633a6c238a22f8e289d0d4e29957eb578d48f7 /drivers/misc | |
| parent | 8bf03f557d6c6e108cf47bea32f4a68e276e1157 (diff) | |
| download | linux-295faa17722a11cac8dbf51e4c9f9405a5e07ef1.tar.bz2 | |
ocxl: fix possible name leak in ocxl_file_register_afu()
If device_register() returns error in ocxl_file_register_afu(),
the name allocated by dev_set_name() need be freed. As comment
of device_register() says, it should use put_device() to give
up the reference in the error path. So fix this by calling
put_device(), then the name can be freed in kobject_cleanup(),
and info is freed in info_release().
Fixes: 75ca758adbaf ("ocxl: Create a clear delineation between ocxl backend & frontend")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Andrew Donnellan <ajd@linux.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20221111145929.2429271-1-yangyingliang@huawei.com
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/ocxl/file.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index d46dba2df5a1..452d5777a0e4 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -541,8 +541,11 @@ int ocxl_file_register_afu(struct ocxl_afu *afu) goto err_put; rc = device_register(&info->dev); - if (rc) - goto err_put; + if (rc) { + free_minor(info); + put_device(&info->dev); + return rc; + } rc = ocxl_sysfs_register_afu(info); if (rc) |