summaryrefslogtreecommitdiffstats
path: root/drivers/misc/eeprom
diff options
context:
space:
mode:
authorMark Brown <broonie@kernel.org>2016-04-20 10:16:35 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-05-01 14:04:19 -0700
commit96b2a45c66fdca543cd94da3aa2c2542b11b9188 (patch)
tree911b0e4c3fcd2ea04337b32736b2e14bad8b3519 /drivers/misc/eeprom
parent8f8f41d160747fda572eed785a5aa022f59f21ca (diff)
downloadlinux-96b2a45c66fdca543cd94da3aa2c2542b11b9188.tar.bz2
eeprom: at25: Fix SPI device leak
The at25 driver is using spi_dev_get() apparently just to take a copy of the SPI device used to instantiate it but never calls spi_dev_put() to free it. Since the device is guaranteed to exist between probe() and remove() there should be no need for the driver to take an extra reference to it so fix the leak by just using a straight assignment. Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/eeprom')
-rw-r--r--drivers/misc/eeprom/at25.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index a2858b33585e..2c6c7c8e3ead 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -345,7 +345,7 @@ static int at25_probe(struct spi_device *spi)
mutex_init(&at25->lock);
at25->chip = chip;
- at25->spi = spi_dev_get(spi);
+ at25->spi = spi;
spi_set_drvdata(spi, at25);
at25->addrlen = addrlen;