diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-07-31 11:55:38 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2022-09-28 16:09:50 +0100 |
| commit | 557244f6284f30613f2d61f14b579303165876c3 (patch) | |
| tree | 088bd8774372bd9249b4b4afd10854aaf2f226ec /drivers/mfd/lp8788-irq.c | |
| parent | becfdcd75126b20b8ec10066c5e85b34f8994ad5 (diff) | |
| download | linux-557244f6284f30613f2d61f14b579303165876c3.tar.bz2 | |
mfd: lp8788: Fix an error handling path in lp8788_irq_init() and lp8788_irq_init()
In lp8788_irq_init(), if an error occurs after a successful
irq_domain_add_linear() call, it must be undone by a corresponding
irq_domain_remove() call.
irq_domain_remove() should also be called in lp8788_irq_exit() for the same
reason.
Fixes: eea6b7cc53aa ("mfd: Add lp8788 mfd driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/bcd5a72c9c1c383dd6324680116426e32737655a.1659261275.git.christophe.jaillet@wanadoo.fr
Diffstat (limited to 'drivers/mfd/lp8788-irq.c')
| -rw-r--r-- | drivers/mfd/lp8788-irq.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c index 348439a3fbbd..39006297f3d2 100644 --- a/drivers/mfd/lp8788-irq.c +++ b/drivers/mfd/lp8788-irq.c @@ -175,6 +175,7 @@ int lp8788_irq_init(struct lp8788 *lp, int irq) IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lp8788-irq", irqd); if (ret) { + irq_domain_remove(lp->irqdm); dev_err(lp->dev, "failed to create a thread for IRQ_N\n"); return ret; } @@ -188,4 +189,6 @@ void lp8788_irq_exit(struct lp8788 *lp) { if (lp->irq) free_irq(lp->irq, lp->irqdm); + if (lp->irqdm) + irq_domain_remove(lp->irqdm); } |