summaryrefslogtreecommitdiffstats
path: root/drivers/media
diff options
context:
space:
mode:
authorStanimir Varbanov <stanimir.varbanov@linaro.org>2020-03-03 12:15:32 +0100
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-03-12 11:50:20 +0100
commit808431d6deacdbb34fdd1b59b622bc54cc444485 (patch)
tree93fddbf0a6239ecf4b8e4355a2f91e32fb244576 /drivers/media
parenteceeea5481d4eeb6073e8ccb2f229bb0dd14a44d (diff)
downloadlinux-808431d6deacdbb34fdd1b59b622bc54cc444485.tar.bz2
media: venus: vdec: Fix forgotten mutex unlock in start streaming
This fixes the following smatch warning in the error path: drivers/media/platform/qcom/venus/vdec.c:968 vdec_start_streaming() warn: inconsistent returns 'mutex:&inst->lock'. Locked on: line 952 Unlocked on: line 963 line 968 by goto mutex unlock. Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media')
-rw-r--r--drivers/media/platform/qcom/venus/vdec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index f349201c0f0d..4ed2628585a1 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -949,7 +949,7 @@ static int vdec_start_streaming(struct vb2_queue *q, unsigned int count)
ret = venus_pm_acquire_core(inst);
if (ret)
- return ret;
+ goto error;
if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
ret = vdec_start_capture(inst);