From 808431d6deacdbb34fdd1b59b622bc54cc444485 Mon Sep 17 00:00:00 2001 From: Stanimir Varbanov Date: Tue, 3 Mar 2020 12:15:32 +0100 Subject: media: venus: vdec: Fix forgotten mutex unlock in start streaming This fixes the following smatch warning in the error path: drivers/media/platform/qcom/venus/vdec.c:968 vdec_start_streaming() warn: inconsistent returns 'mutex:&inst->lock'. Locked on: line 952 Unlocked on: line 963 line 968 by goto mutex unlock. Signed-off-by: Stanimir Varbanov Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/qcom/venus/vdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/media') diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c index f349201c0f0d..4ed2628585a1 100644 --- a/drivers/media/platform/qcom/venus/vdec.c +++ b/drivers/media/platform/qcom/venus/vdec.c @@ -949,7 +949,7 @@ static int vdec_start_streaming(struct vb2_queue *q, unsigned int count) ret = venus_pm_acquire_core(inst); if (ret) - return ret; + goto error; if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) ret = vdec_start_capture(inst); -- cgit v1.2.3