diff options
| author | Matthias Kaehlcke <mka@chromium.org> | 2022-09-07 13:30:58 -0700 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2022-09-07 16:37:27 -0700 |
| commit | 916ef6232cc4b84db7082b4c3d3cf1753d9462ba (patch) | |
| tree | bce625a93d60639ce4c7d9e4fa7842af1a20d197 /drivers/md/dm-verity-loadpin.c | |
| parent | aafc203bbad4bf6cf394a34ea698c2b0b8affae0 (diff) | |
| download | linux-916ef6232cc4b84db7082b4c3d3cf1753d9462ba.tar.bz2 | |
dm: verity-loadpin: Only trust verity targets with enforcement
Verity targets can be configured to ignore corrupted data blocks.
LoadPin must only trust verity targets that are configured to
perform some kind of enforcement when data corruption is detected,
like returning an error, restarting the system or triggering a
panic.
Fixes: b6c1c5745ccc ("dm: Add verity helpers for LoadPin")
Reported-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Sarthak Kukreti <sarthakkukreti@chromium.org>
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220907133055.1.Ic8a1dafe960dc0f8302e189642bc88ebb785d274@changeid
Diffstat (limited to 'drivers/md/dm-verity-loadpin.c')
| -rw-r--r-- | drivers/md/dm-verity-loadpin.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/drivers/md/dm-verity-loadpin.c b/drivers/md/dm-verity-loadpin.c index 387ec43aef72..4f78cc55c251 100644 --- a/drivers/md/dm-verity-loadpin.c +++ b/drivers/md/dm-verity-loadpin.c @@ -14,6 +14,7 @@ LIST_HEAD(dm_verity_loadpin_trusted_root_digests); static bool is_trusted_verity_target(struct dm_target *ti) { + int verity_mode; u8 *root_digest; unsigned int digest_size; struct dm_verity_loadpin_trusted_root_digest *trd; @@ -22,6 +23,13 @@ static bool is_trusted_verity_target(struct dm_target *ti) if (!dm_is_verity_target(ti)) return false; + verity_mode = dm_verity_get_mode(ti); + + if ((verity_mode != DM_VERITY_MODE_EIO) && + (verity_mode != DM_VERITY_MODE_RESTART) && + (verity_mode != DM_VERITY_MODE_PANIC)) + return false; + if (dm_verity_get_root_digest(ti, &root_digest, &digest_size)) return false; |