summaryrefslogtreecommitdiffstats
path: root/drivers/mailbox/qcom-ipcc.c
diff options
context:
space:
mode:
authorBjörn Ardö <bjorn.ardo@axis.com>2022-03-31 09:01:15 +0200
committerJassi Brar <jaswinder.singh@linaro.org>2022-05-23 14:45:24 -0500
commitbca1a1004615efe141fd78f360ecc48c60bc4ad5 (patch)
tree613778031a210959ddaa28710e86d5180bd2ffca /drivers/mailbox/qcom-ipcc.c
parentc25f77899753fdd6f43fa6999abd53fd0059496e (diff)
downloadlinux-bca1a1004615efe141fd78f360ecc48c60bc4ad5.tar.bz2
mailbox: forward the hrtimer if not queued and under a lock
This reverts commit c7dacf5b0f32957b24ef29df1207dc2cd8307743, "mailbox: avoid timer start from callback" The previous commit was reverted since it lead to a race that caused the hrtimer to not be started at all. The check for hrtimer_active() in msg_submit() will return true if the callback function txdone_hrtimer() is currently running. This function could return HRTIMER_NORESTART and then the timer will not be restarted, and also msg_submit() will not start the timer. This will lead to a message actually being submitted but no timer will start to check for its compleation. The original fix that added checking hrtimer_active() was added to avoid a warning with hrtimer_forward. Looking in the kernel another solution to avoid this warning is to check hrtimer_is_queued() before calling hrtimer_forward_now() instead. This however requires a lock so the timer is not started by msg_submit() inbetween this check and the hrtimer_forward() call. Fixes: c7dacf5b0f32 ("mailbox: avoid timer start from callback") Signed-off-by: Björn Ardö <bjorn.ardo@axis.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox/qcom-ipcc.c')
0 files changed, 0 insertions, 0 deletions