summaryrefslogtreecommitdiffstats
path: root/drivers/input/serio
diff options
context:
space:
mode:
authorSudeep Holla <sudeep.holla@arm.com>2016-11-16 17:01:26 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2016-11-17 09:16:33 -0800
commitdadbb0aa363bf1233f75cab23977add69d197e23 (patch)
tree96c3b67ec3568e8b9c7e04bb31f46e1c03ad6e0b /drivers/input/serio
parentfac96cc9f8679e31a244f98bed5983fe220e295c (diff)
downloadlinux-dadbb0aa363bf1233f75cab23977add69d197e23.tar.bz2
Input: gpio_keys - set input direction explicitly
Commit 700a38b27eef ("Input: gpio_keys - switch to using generic device properties") switched to use generic device properties for GPIO keys and commit 5feeca3c1e39 ("Input: gpio_keys - add support for GPIO descriptors") switched from legacy GPIO numbers to GPIO descriptors. Previously devm_gpio_request_one was explicitly passed GPIOF_DIR_IN flag to set the GPIO direction as input. However devm_get_gpiod_from_child doesn't have such provisions and hence fwnode_get_named_gpiod can't set it as input. This breaks few platforms with the following error: " gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ unable to lock HW IRQ <n> for IRQ genirq: Failed to request resources for POWER (irq <x>) on irqchip gpio_keys: Unable to claim irq <x>; error -22 gpio-keys: probe failed with error -22 " This patch fixes the issue by setting input direction explicitly for gpio lines described by generic properties. Fixes: 700a38b27eef ("Input: gpio_keys - switch to using generic device properties") Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/serio')
0 files changed, 0 insertions, 0 deletions