summaryrefslogtreecommitdiffstats
path: root/drivers/input/serio
diff options
context:
space:
mode:
authorZhang Qilong <zhangqilong3@huawei.com>2020-11-20 16:36:49 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2020-11-22 21:26:31 -0800
commit59bbf83835f591b95c3bdd09d900f3584fa227af (patch)
treebc5acbbceb0a4909a50bc710c2d06cba670f6c15 /drivers/input/serio
parent3aa40a1ad36717114d9a267b08d884a387489fab (diff)
downloadlinux-59bbf83835f591b95c3bdd09d900f3584fa227af.tar.bz2
Input: omap4-keypad - fix runtime PM error handling
In omap4_keypad_probe, the patch fix several bugs. 1) pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak. 2) In err_unmap, forget to disable runtime of device, pm_runtime_enable will increase power disable depth. Thus a pairing decrement is needed on the error handling path to keep it balanced. 3) In err_pm_disable, it will call pm_runtime_put_sync twice not one time. To fix this we factor out code reading revision and disabling touchpad, and drop PM reference once we are done talking to the device. Fixes: f77621cc640a7 ("Input: omap-keypad - dynamically handle register offsets") Fixes: 5ad567ffbaf20 ("Input: omap4-keypad - wire up runtime PM handling") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Link: https://lore.kernel.org/r/20201120133918.2559681-1-zhangqilong3@huawei.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/serio')
0 files changed, 0 insertions, 0 deletions