diff options
author | John Fastabend <john.fastabend@gmail.com> | 2019-11-21 08:25:09 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-11-21 13:43:45 -0800 |
commit | 8163999db445021f2651a8a47b5632483e8722ea (patch) | |
tree | 044f73c60b4d6d2becf9a03c5c78170d7dbe1e98 /drivers/input/rmi4 | |
parent | 7599a896f2e46e9c072e02a8299a67d4d2f96675 (diff) | |
download | linux-8163999db445021f2651a8a47b5632483e8722ea.tar.bz2 |
bpf: skmsg, fix potential psock NULL pointer dereference
Report from Dan Carpenter,
net/core/skmsg.c:792 sk_psock_write_space()
error: we previously assumed 'psock' could be null (see line 790)
net/core/skmsg.c
789 psock = sk_psock(sk);
790 if (likely(psock && sk_psock_test_state(psock, SK_PSOCK_TX_ENABLED)))
Check for NULL
791 schedule_work(&psock->work);
792 write_space = psock->saved_write_space;
^^^^^^^^^^^^^^^^^^^^^^^^
793 rcu_read_unlock();
794 write_space(sk);
Ensure psock dereference on line 792 only occurs if psock is not null.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 604326b41a6f ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/input/rmi4')
0 files changed, 0 insertions, 0 deletions