diff options
| author | Gal Pressman <galpress@amazon.com> | 2019-06-13 12:10:13 +0300 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2019-06-21 11:52:44 -0400 |
| commit | b41f75724ab8aeeba1001e63c31db8623432f001 (patch) | |
| tree | 8b89e0abd797575d5158622299c15fb18c283518 /drivers/infiniband/hw/efa/efa_com_cmd.c | |
| parent | 40ddb3f020834f9afb7aab31385994811f4db259 (diff) | |
| download | linux-b41f75724ab8aeeba1001e63c31db8623432f001.tar.bz2 | |
RDMA/efa: Be consistent with success flow return value
The EFA driver is written with success oriented flows in mind, meaning
that functions should mostly end with a return 0 statement.
Error flows return their error value on their own instead of assuming
that the function will return the error at the end.
This commit fixes a bunch of functions that were not aligned with this
behavior.
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw/efa/efa_com_cmd.c')
| -rw-r--r-- | drivers/infiniband/hw/efa/efa_com_cmd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/efa/efa_com_cmd.c b/drivers/infiniband/hw/efa/efa_com_cmd.c index 91e7f2195802..d2464c8390bb 100644 --- a/drivers/infiniband/hw/efa/efa_com_cmd.c +++ b/drivers/infiniband/hw/efa/efa_com_cmd.c @@ -56,7 +56,7 @@ int efa_com_create_qp(struct efa_com_dev *edev, res->send_sub_cq_idx = cmd_completion.send_sub_cq_idx; res->recv_sub_cq_idx = cmd_completion.recv_sub_cq_idx; - return err; + return 0; } int efa_com_modify_qp(struct efa_com_dev *edev, @@ -178,7 +178,7 @@ int efa_com_create_cq(struct efa_com_dev *edev, result->cq_idx = cmd_completion.cq_idx; result->actual_depth = params->cq_depth; - return err; + return 0; } int efa_com_destroy_cq(struct efa_com_dev *edev, |