summaryrefslogtreecommitdiffstats
path: root/drivers/iio/magnetometer/ak8975.c
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2020-07-22 16:50:48 +0100
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2020-08-22 11:38:58 +0100
commit2684d5003490df5398aeafe2592ba9d4a4653998 (patch)
treefc7d1d6f2f3569bcf64ba6a10d7de2cb271edaaa /drivers/iio/magnetometer/ak8975.c
parent523628852a5f5f34a15252b2634d0498d3cfb347 (diff)
downloadlinux-2684d5003490df5398aeafe2592ba9d4a4653998.tar.bz2
iio:light:ltr501 Fix timestamp alignment issue.
One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses an array of smaller elements on the stack. Here we use a structure on the stack. The driver already did an explicit memset so no data leak was possible. Forced alignment of ts is not strictly necessary but probably makes the code slightly less fragile. Note there has been some rework in this driver of the years, so no way this will apply cleanly all the way back. Fixes: 2690be905123 ("iio: Add Lite-On ltr501 ambient light / proximity sensor driver") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: <Stable@vger.kernel.org>
Diffstat (limited to 'drivers/iio/magnetometer/ak8975.c')
0 files changed, 0 insertions, 0 deletions