diff options
| author | Cai Huoqing <caihuoqing@baidu.com> | 2021-09-28 09:38:58 +0800 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2021-10-19 08:30:43 +0100 |
| commit | d5c1118f6faf41704484b86e160769a2ccec3c39 (patch) | |
| tree | 57c253af65280fd1ad83ade919f3bb3ec8ee1d13 /drivers/iio/dac/max5821.c | |
| parent | 2b87c267d84ffba458efafb0b342fb082ddb24eb (diff) | |
| download | linux-d5c1118f6faf41704484b86e160769a2ccec3c39.tar.bz2 | |
iio: dac: max5821: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-5-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/dac/max5821.c')
| -rw-r--r-- | drivers/iio/dac/max5821.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/iio/dac/max5821.c b/drivers/iio/dac/max5821.c index bd0b7f361154..7da4710a6408 100644 --- a/drivers/iio/dac/max5821.c +++ b/drivers/iio/dac/max5821.c @@ -321,12 +321,9 @@ static int max5821_probe(struct i2c_client *client, } data->vref_reg = devm_regulator_get(&client->dev, "vref"); - if (IS_ERR(data->vref_reg)) { - ret = PTR_ERR(data->vref_reg); - dev_err(&client->dev, - "Failed to get vref regulator: %d\n", ret); - return ret; - } + if (IS_ERR(data->vref_reg)) + return dev_err_probe(&client->dev, PTR_ERR(data->vref_reg), + "Failed to get vref regulator\n"); ret = regulator_enable(data->vref_reg); if (ret) { |