diff options
| author | Qinglang Miao <miaoqinglang@huawei.com> | 2020-12-01 17:31:40 +0800 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-04-14 09:49:09 +0200 |
| commit | 278e5bbdb9a94fa063c0f9bcde2479d0b8042462 (patch) | |
| tree | 3551eab19a61f9a47569ff55ba2dec9cf9687155 /drivers/i2c | |
| parent | 223125e37af8a641ea4a09747a6a52172fc4b903 (diff) | |
| download | linux-278e5bbdb9a94fa063c0f9bcde2479d0b8042462.tar.bz2 | |
i2c: imx-lpi2c: fix reference leak when pm_runtime_get_sync fails
The PM reference count is not expected to be incremented on
return in lpi2c_imx_master_enable.
However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here.
Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.
Fixes: 13d6eb20fc79 ("i2c: imx-lpi2c: add runtime pm support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-imx-lpi2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c index 9db6ccded5e9..8b9ba055c418 100644 --- a/drivers/i2c/busses/i2c-imx-lpi2c.c +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c @@ -259,7 +259,7 @@ static int lpi2c_imx_master_enable(struct lpi2c_imx_struct *lpi2c_imx) unsigned int temp; int ret; - ret = pm_runtime_get_sync(lpi2c_imx->adapter.dev.parent); + ret = pm_runtime_resume_and_get(lpi2c_imx->adapter.dev.parent); if (ret < 0) return ret; |