summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/tidss/tidss_kms.c
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2021-03-23 23:50:08 +0200
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2021-07-28 16:33:12 +0300
commitfb8d617f8fd64f52f62e4f782aed64d1754ed33b (patch)
tree7e3cd439909f419bc2e898b99eb3fd577f6dfd53 /drivers/gpu/drm/tidss/tidss_kms.c
parent5e7ef0b85c7718c10f6122caf7af9b2e70d53830 (diff)
downloadlinux-fb8d617f8fd64f52f62e4f782aed64d1754ed33b.tar.bz2
drm/bridge: Centralize error message when bridge attach fails
Being informed of a failure to attach a bridge is useful, and many drivers prints an error message in that case. Move the message to drm_bridge_attach() to avoid code duplication. Suggested-by: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Reviewed-by: Jyri Sarha <jyri.sarha@iki.fi>
Diffstat (limited to 'drivers/gpu/drm/tidss/tidss_kms.c')
-rw-r--r--drivers/gpu/drm/tidss/tidss_kms.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c
index 95f8e0f78e32..666e527a0acf 100644
--- a/drivers/gpu/drm/tidss/tidss_kms.c
+++ b/drivers/gpu/drm/tidss/tidss_kms.c
@@ -227,10 +227,8 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss)
}
ret = drm_bridge_attach(enc, pipes[i].bridge, NULL, 0);
- if (ret) {
- dev_err(tidss->dev, "bridge attach failed: %d\n", ret);
+ if (ret)
return ret;
- }
}
/* create overlay planes of the leftover planes */