diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-08-04 16:32:39 +0100 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2016-08-04 20:20:04 +0100 |
commit | 573adb396241e2aa46401529abdba93bc1886a48 (patch) | |
tree | 329d217776c51c5a7a71e7532994098977cdd072 /drivers/gpu/drm/i915/i915_gem_request.c | |
parent | 5748b6a1f48eae5b8513dd88ab6da4c176686665 (diff) | |
download | linux-573adb396241e2aa46401529abdba93bc1886a48.tar.bz2 |
drm/i915: Move obj->active:5 to obj->flags
We are motivated to avoid using a bitfield for obj->active for a couple
of reasons. Firstly, we wish to document our lockless read of obj->active
using READ_ONCE inside i915_gem_busy_ioctl() and that requires an
integral type (i.e. not a bitfield). Secondly, gcc produces abysmal code
when presented with a bitfield and that shows up high on the profiles of
request tracking (mainly due to excess memory traffic as it converts
the bitfield to a register and back and generates frequent AGI in the
process).
v2: BIT, break up a long line in compute the other engines, new paint
for i915_gem_object_is_active (now i915_gem_object_get_active).
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1470324762-2545-23-git-send-email-chris@chris-wilson.co.uk
Diffstat (limited to 'drivers/gpu/drm/i915/i915_gem_request.c')
0 files changed, 0 insertions, 0 deletions