summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/drm_atomic_state_helper.c
diff options
context:
space:
mode:
authorhersen wu <hersenxs.wu@amd.com>2020-07-06 09:18:25 -0400
committerAlex Deucher <alexander.deucher@amd.com>2020-07-14 14:34:24 -0400
commit1f9ce3cf18ed441a0df8f2447c6f9d6556780415 (patch)
treea5cfd41d05de24e4999c5ecc740fb29a6fc5b9a4 /drivers/gpu/drm/drm_atomic_state_helper.c
parentec11fe3705a7d434ec3493bdaddb9b6367e7366a (diff)
downloadlinux-1f9ce3cf18ed441a0df8f2447c6f9d6556780415.tar.bz2
drm/amd/display: p-state warning occurs while changing resolution from 120hz to 60hz
[Why] new calculated dispclk, dppclk are stored in context->bw_ctx.bw.dcn.clk.dispclk_khz, dppclk_khz. Current dispclk, dppclk are from dc->clk_mgr->clks.dispclk_khz. dcn_validate_bandwidth compute new dispclk, dppclk. dispclk will put in use after optimize_bandwidth when ramp_up_dispclk_with_dpp is called. There are two places for dppclk be put in use. One location is the same as the location as dispclk. Another is within update_dchubp_dpp which happens between pre_bandwidth and optimize_bandwidth. dppclk updated within update_dchubp_dpp will cause new clock values of dispclk and dppclk not be in use at the same time. when clocks are decreased, this may cause dppclk is lower than current configuration and let pipe stuck. for example, eDP + external dp, change resolution of DP from 1920x1080x144hz to 1280x960x60hz. before change: dispclk = 337889 dppclk = 337889 change mode, dcn_validate_bandwidth calculate dispclk = 143122 dppclk = 143122 update_dchubp_dpp be executed before dispclk be updated, dispclk = 337889, but dppclk use new value dispclk /2 = 168944. this will cause pipe pstate warning issue. [How] between pre_bandwidth and optimize_bandwidth, while dispclk is going to be decreased, keep dppclk = dispclk Signed-off-by: Hersen Wu <hersenxs.wu@amd.com> Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com> Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers/gpu/drm/drm_atomic_state_helper.c')
0 files changed, 0 insertions, 0 deletions