diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-11-25 13:24:51 +0300 |
|---|---|---|
| committer | Oded Gabbay <oded.gabbay@amd.com> | 2014-11-25 13:24:51 +0300 |
| commit | e048a0b26033b35eb36c20e4d36fb466a2570c27 (patch) | |
| tree | 5e9ea640dacbf9fce33ef1290785ef5840795aff /drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | |
| parent | 66333cb3d7d4ff853b6945f01e68d8986d821235 (diff) | |
| download | linux-e048a0b26033b35eb36c20e4d36fb466a2570c27.tar.bz2 | |
amdkfd: fix an error handling bug in pqm_create_queue()
The call to kernel_queue_uninit(NULL) will trigger a BUG(), and also the
error code is incorrect.
Fixes: 45102048f77e ('amdkfd: Add process queue manager module')
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
Diffstat (limited to 'drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c')
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c index de2c16345693..47526780d736 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c @@ -208,7 +208,7 @@ int pqm_create_queue(struct process_queue_manager *pqm, case KFD_QUEUE_TYPE_DIQ: kq = kernel_queue_init(dev, KFD_QUEUE_TYPE_DIQ); if (kq == NULL) { - kernel_queue_uninit(kq); + retval = -ENOMEM; goto err_create_queue; } kq->queue->properties.queue_id = *qid; |