summaryrefslogtreecommitdiffstats
path: root/drivers/gpio/gpio-menz127.c
diff options
context:
space:
mode:
authorNadav Amit <namit@vmware.com>2018-06-04 06:58:14 -0700
committerLinus Walleij <linus.walleij@linaro.org>2018-06-18 07:55:30 +0200
commit7279d9917560bbd0d82813d6bf00490a82c06783 (patch)
tree2b09b42b48cc36d169fcde66720240478c559d54 /drivers/gpio/gpio-menz127.c
parentce397d215ccd07b8ae3f71db689aedb85d56ab40 (diff)
downloadlinux-7279d9917560bbd0d82813d6bf00490a82c06783.tar.bz2
gpio: Fix wrong rounding in gpio-menz127
men_z127_debounce() tries to round up and down, but uses functions which are only suitable when the divider is a power of two, which is not the case. Use the appropriate ones. Found by static check. Compile tested. Fixes: f436bc2726c64 ("gpio: add driver for MEN 16Z127 GPIO controller") Signed-off-by: Nadav Amit <namit@vmware.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/gpio/gpio-menz127.c')
-rw-r--r--drivers/gpio/gpio-menz127.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-menz127.c b/drivers/gpio/gpio-menz127.c
index e1037582e34d..b2635326546e 100644
--- a/drivers/gpio/gpio-menz127.c
+++ b/drivers/gpio/gpio-menz127.c
@@ -56,9 +56,9 @@ static int men_z127_debounce(struct gpio_chip *gc, unsigned gpio,
rnd = fls(debounce) - 1;
if (rnd && (debounce & BIT(rnd - 1)))
- debounce = round_up(debounce, MEN_Z127_DB_MIN_US);
+ debounce = roundup(debounce, MEN_Z127_DB_MIN_US);
else
- debounce = round_down(debounce, MEN_Z127_DB_MIN_US);
+ debounce = rounddown(debounce, MEN_Z127_DB_MIN_US);
if (debounce > MEN_Z127_DB_MAX_US)
debounce = MEN_Z127_DB_MAX_US;