diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-10-12 17:39:28 +0200 |
---|---|---|
committer | Bartosz Golaszewski <brgl@bgdev.pl> | 2021-10-13 19:52:41 +0200 |
commit | f4a20dfac88c06c9b529a41ff4cf9acba8f3fdff (patch) | |
tree | 2e7f25a303958a32f8b54cd91c61878b9af4bc8d /drivers/gpio/gpio-mc33880.c | |
parent | 06de2cd788bfa3b51137e9bd471d68029ab68103 (diff) | |
download | linux-f4a20dfac88c06c9b529a41ff4cf9acba8f3fdff.tar.bz2 |
gpio: mc33880: Drop if with an always false condition
An spi remove callback is only called for devices that probed
successfully. In this case this implies that mc33880_probe() set a
non-NULL driver data. So the check for mc being NULL is never true and
the check can be dropped.
Also the return value ofspi remove callbacks is ignored anyway.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Diffstat (limited to 'drivers/gpio/gpio-mc33880.c')
-rw-r--r-- | drivers/gpio/gpio-mc33880.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c index f8194f7c6186..31d2be1bebc8 100644 --- a/drivers/gpio/gpio-mc33880.c +++ b/drivers/gpio/gpio-mc33880.c @@ -139,8 +139,6 @@ static int mc33880_remove(struct spi_device *spi) struct mc33880 *mc; mc = spi_get_drvdata(spi); - if (!mc) - return -ENODEV; gpiochip_remove(&mc->chip); mutex_destroy(&mc->lock); |