diff options
author | Liran Alon <liran.alon@oracle.com> | 2020-01-03 18:44:59 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-01-03 12:40:53 -0800 |
commit | b54ef37b1ce892fdf6b632d566246d2f2f539910 (patch) | |
tree | b52c82984379aaab718a28a7004f9f6245abb374 /drivers/dma | |
parent | eed70fd9452fe0fcd1a221731a4333b51a8081f2 (diff) | |
download | linux-b54ef37b1ce892fdf6b632d566246d2f2f539910.tar.bz2 |
net: Google gve: Remove dma_wmb() before ringing doorbell
Current code use dma_wmb() to ensure Rx/Tx descriptors are visible
to device before writing to doorbell.
However, these dma_wmb() are wrong and unnecessary. Therefore,
they should be removed.
iowrite32be() called from gve_rx_write_doorbell()/gve_tx_put_doorbell()
should guaratee that all previous writes to WB/UC memory is visible to
device before the write done by iowrite32be().
E.g. On ARM64, iowrite32be() calls __iowmb() which expands to dma_wmb()
and only then calls __raw_writel().
Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/dma')
0 files changed, 0 insertions, 0 deletions